Error Handling + Helper Text #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gehrkej
changed the title
Gehrkej
force-pushed
the
Gehrkej/Attempt-Input-Error-Handling
branch
from
b9cce39
to
2b0dd66
Compare
* Result screens unified! * fixed the display bug in result * added title to styles, some redundancy removed from barChartScreen --------- Co-authored-by: Jake Gehrke <gehrkej@oregonstate.edu>
* plan hooked fully to database and finished by submitting drill * scroll down to refresh * change naming to be more clear and requre drill id and assigned_time * add assigned_data to user on user creation * fix key issue, lighter green, squircle, spacing of description * styling * updated prettier and github action settings to be more strict * code cleanup * ran pretty * attemptRefId into attemptId --------- Co-authored-by: Frankreed <baoanhtdn@gmail.com>
….com/Golf-Drill-Challenge-App/Golf-App into Gehrkej/Attempt-Input-Error-Handling
Gehrkej
changed the title
This was referenced Apr 9, 2024
FrankreedX
requested changes
Apr 9, 2024
|
In the files changed tab, there are a lot of repeated changes to layout. Try rebasing again maybe? |
….com/Golf-Drill-Challenge-App/Golf-App into Gehrkej/Attempt-Input-Error-Handling
….com/Golf-Drill-Challenge-App/Golf-App into Gehrkej/Attempt-Input-Error-Handling
…s, and fixed calculateProxHole cuz I was stupid...
FrankreedX
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR mostly is enhancing the submission flow to provide more feedback and guidance to users. This includes a new Dialog telling the user if they have entered an invalid character (non-number), adjusting empty input banner to be a dialog and account for deleted inputs, and adding helper text under the sideLanding input. Additionally, the database and codebase is set up in a way that will support helper text for other inputs if warranted.
Related Issue(s): #93 #97 #126
Features
Other Notes