fix: regression in serialization #2928
Merged
+36
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OrKoN I extended an e2e test |
sadym-chromium
approved these changes
Jan 2, 2025
sadym-chromium
approved these changes
Jan 2, 2025
sadym-chromium
force-pushed
the
orkon/fix-serialization-issue
branch
from
0bdf075 to
6c604e9
Compare
sadym-chromium
force-pushed
the
orkon/fix-serialization-issue
branch
from
6c604e9 to
163246a
Compare
sadym-chromium
pushed a commit
that referenced
this pull request
Jan 3, 2025
🤖 I have created a release *beep* *boop* --- ## [0.12.0](chromium-bidi-v0.11.1...chromium-bidi-v0.12.0) (2025-01-03) ### Features * provide proper network timings ([#2919](#2919)) ([22e096b](22e096b)) ### Bug Fixes * regression in serialization ([#2928](#2928)) ([84f9983](84f9983)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deeply nested nodes do not include values in CDP, thus, Object.hasOwn throws an error because only objects are allowed as the first arg.
Drive-by: improve types
Caused by: #2622
Addresses: puppeteer/puppeteer#13433
WPT test: https://github.com/web-platform-tests/wpt/pull/49821/files