Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Create basic explorable explanation timeline and flow #858

Merged
merged 21 commits into from
Oct 29, 2024

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Oct 24, 2024

Description

This PR creates a basic EE timeline and flow diagram for Protected Audience, which will also be used for Topics. For rapid development, we've temporarily created an ee directory in the root folder with its own webpack setup. This setup is not integrated with the extension and will be removed later.

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    - [ ] This code is covered by unit tests to verify that it works as intended. NA
    - [ ] The QA of this PR is done by a member of the QA team (to be checked by QA). NA

Partially Fixes #857

@mohdsayed mohdsayed self-assigned this Oct 24, 2024
@mohdsayed mohdsayed added the feature Feature/capability of the tool label Oct 24, 2024
@amovar18 amovar18 marked this pull request as ready for review October 25, 2024 02:54
@amovar18 amovar18 requested a review from mayan-000 October 25, 2024 02:54
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed added this to the v0.12 milestone Oct 29, 2024
@mohdsayed mohdsayed merged commit 5d9f3be into develop Oct 29, 2024
6 checks passed
@mohdsayed mohdsayed deleted the feat/ee-pa branch October 29, 2024 06:37
amovar18 added a commit that referenced this pull request Dec 12, 2024
* Add explorable-explanation directory

* Move easier calculations to psat.

* Fix color calculation and font family.

* Move icons to its own file

* Small improvements

* Add p5 to package.json so that it can be resolved in Github workflow

* Refactor code to calculate canvas dimensions

* Use Promise.all

* Remove unused key value pairs

* Refactor code to remove repeated code

* Refactor code to use colors from config

* Fix feedback

* Move circles with user icon.

* Add animation to move interest group with low opacity into runAdAuction.

* Refactor code:
Add spaces
Add comments.

* Remove unnecessary code.

* Add group of concentric ring of bubbles.

* Add mainCanvasWipe and recreate.
Add utility to check if function click was inside circle.

* Change user icon

* Remove border from small circles

* Add another canvas layer and manage animations.

---------

Co-authored-by: Amoghavarsha Kudaligi <kgamoghavarsha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature/capability of the tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants