-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Create basic explorable explanation timeline and flow #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Add spaces Add comments.
Add utility to check if function click was inside circle.
amovar18
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
amovar18
added a commit
that referenced
this pull request
Dec 12, 2024
* Add explorable-explanation directory * Move easier calculations to psat. * Fix color calculation and font family. * Move icons to its own file * Small improvements * Add p5 to package.json so that it can be resolved in Github workflow * Refactor code to calculate canvas dimensions * Use Promise.all * Remove unused key value pairs * Refactor code to remove repeated code * Refactor code to use colors from config * Fix feedback * Move circles with user icon. * Add animation to move interest group with low opacity into runAdAuction. * Refactor code: Add spaces Add comments. * Remove unnecessary code. * Add group of concentric ring of bubbles. * Add mainCanvasWipe and recreate. Add utility to check if function click was inside circle. * Change user icon * Remove border from small circles * Add another canvas layer and manage animations. --------- Co-authored-by: Amoghavarsha Kudaligi <kgamoghavarsha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a basic EE timeline and flow diagram for Protected Audience, which will also be used for Topics. For rapid development, we've temporarily created an ee directory in the root folder with its own webpack setup. This setup is not integrated with the extension and will be removed later.
Relevant Technical Choices
Testing Instructions
Additional Information:
Screenshot/Screencast
Checklist
- [ ] This code is covered by unit tests to verify that it works as intended.NA- [ ] The QA of this PR is done by a member of the QA team (to be checked by QA).NAPartially Fixes #857