Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add previous and next buttons for EE PA #872

Merged
merged 16 commits into from
Nov 24, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Nov 21, 2024

Description

This PR aims to add Previous and Next buttons to the canvas where in if the user is in non-interactive mode and clicks on next button the user icon will move into the next website.

Relevant Technical Choices

Testing Instructions

  • Clone this branch
  • In the terminal run npm run dev:ee:pa.
  • Now when animation is running click on next and previous button to see the effect

Additional Information:

Screenshot/Screencast

Screen.Recording.2024-11-21.at.16.38.38.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [x] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@amovar18 amovar18 self-assigned this Nov 21, 2024
@amovar18 amovar18 added this to the v0.12 milestone Nov 21, 2024
@amovar18 amovar18 marked this pull request as ready for review November 22, 2024 09:36
@amovar18 amovar18 requested a review from mohdsayed November 22, 2024 09:36
@mohdsayed mohdsayed merged commit e269870 into develop Nov 24, 2024
6 checks passed
@mohdsayed mohdsayed deleted the feat/prev-next-buttons branch November 24, 2024 01:33
amovar18 added a commit that referenced this pull request Dec 12, 2024
* Add next and previous button.

* Fix bug

* Fix condition.

* Fix bubble showing.

* Fix navigation using next and previous buttons.

* Add disable buttons functions.

* Use different variable for cancelling promise.

* Fix animation problems and errors.

* Fix condition for cursor.

* Make the previous and next button invisible when and unclickable in interactive mode.

* Add some performance improvements.

* Fix page unresponsive

* Add spacing.

* Draw user icon.

* Fix bugs in bubbles.

* Use requestAnimationFrame instead of setTimeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants