Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Refactor code, add colored boxes, information icons, and longer line animation duration #881

Merged
merged 18 commits into from
Dec 6, 2024

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Dec 5, 2024

Description

This PR does the following.

  1. Refactor code to separate protected audience and other features like Topics.
  2. Introduce new addCanvasEventListener and removeCanvasEventListener to add and remove event listeners.
  3. Extends Box component to support background color,
  4. Add information icons
  5. Extend ProgressLine component to optionally not have any animation.

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@mohdsayed mohdsayed self-assigned this Dec 5, 2024
@mohdsayed mohdsayed changed the title Feature: Add colored boxes, information icons, and longer line animation duration Feature: Refactor code, add colored boxes, information icons, and longer line animation duration Dec 6, 2024
@mohdsayed mohdsayed added this to the v1.0 milestone Dec 6, 2024
@mohdsayed mohdsayed marked this pull request as ready for review December 6, 2024 05:50
@mohdsayed mohdsayed requested a review from amovar18 December 6, 2024 05:53
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit 89055ad into develop Dec 6, 2024
6 checks passed
@mohdsayed mohdsayed deleted the feat/color-code-boxes branch December 6, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants