Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Expand EE flow from AdUnitBox or DateTimeBranch #903

Merged
merged 12 commits into from
Jan 1, 2025

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Dec 27, 2024

Description

This PR adds support to click and expand the flow from date time branch or adUnitBranch.

Relevant Technical Choices

  • A new component is used which is called after branches are drawn, this event will listen to clicks on the canvas and check the coordinates with the input coordinates of the branches' endpoint.

Testing Instructions

  • Clone this branch.
  • In the terminal run npm i && npm run dev:ee:pa.
  • Once animation flow reaches the branches, the flow stops for user input.
  • Once the user selects on the dropdown arrow from the branches, the next set of flow is drawn.

Additional Information:

Screenshot/Screencast

Screen.Recording.2024-12-27.at.14.05.46.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    - [ ] This code is covered by unit tests to verify that it works as intended. NA
    - [ ] The QA of this PR is done by a member of the QA team (to be checked by QA). NA

Partially addresses #857

@amovar18 amovar18 self-assigned this Dec 27, 2024
@amovar18 amovar18 added this to the v1.0 milestone Dec 27, 2024
@amovar18 amovar18 marked this pull request as ready for review December 30, 2024 07:27
@mohdsayed mohdsayed merged commit f0e98cb into develop Jan 1, 2025
6 checks passed
@mohdsayed mohdsayed deleted the feat/expand-flow branch January 1, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants