fix(issue-230): adding in startupProb to sidecar #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: run
|
Checking in on build trigger test failure |
pattishin
force-pushed
the
fix/issue-230
branch
3 times, most recently
from
e6340e3
to
3a20dac
Compare
…ional log displays before actual expected service
pattishin
commented
Feb 23, 2024
| @@ -40,7 +40,7 @@ then | |||
| fi | |||
|
|
|||
| # Check Cloud Run MC logs for signs of successful request to hello container. | |||
| MC_HELLO_LOG=$(gcloud logging read "resource.type=cloud_run_revision AND resource.labels.service_name=${MC_SERVICE_NAME} AND labels.container_name=hello" --limit 1 | grep -e 'Hello from Cloud Run') | |||
| MC_HELLO_LOG=$(gcloud logging read "resource.type=cloud_run_revision AND resource.labels.service_name=${MC_SERVICE_NAME} AND labels.container_name=hello" --limit 2 | grep -e 'Hello from Cloud Run') | |||
There was a problem hiding this comment.
Note: In tests/e2e-test.sh, updated result limit to 2 to accomodate new startup tcp probe logs now displaying before expected service.
Logs:
textPayload: STARTUP TCP probe succeeded after 1 attempt for container "hello" on port 8888.textPayload: 2024/02/2- --:--:-- Hello from Cloud Run! The container started successfully and is listening for HTTP requests on $PORT
glasnt
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #230