Add basic experimental cache support #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @songjiaxun |
|
/assign dannawang0221 |
songjiaxun
reviewed
Sep 5, 2023
songjiaxun
reviewed
Sep 6, 2023
examples/README.md
Outdated
| @@ -186,3 +186,32 @@ kubectl port-forward jupyter-notebook-server 8888:8888 | |||
| # clean up | |||
| kubectl delete -f ./examples/jupyter/jupyter-notebook-server.yaml | |||
| ``` | |||
|
|
|||
| ## Jupyter Notebook Example (no experimental read cache) | |||
There was a problem hiding this comment.
Do you mean "(with experimental read cache)"?
examples/README.md
Outdated
| # 2. install a Jupyter Notebook server using experimental gcsfuse read cache | ||
| kubectl apply -f ./examples/jupyter/jupyter-experimental-readcache.yaml | ||
|
|
||
| # get service IPs |
There was a problem hiding this comment.
Could you also add the sequence number for this and the following steps? Or just remove the numbers 1, 2 from the above steps?
There was a problem hiding this comment.
Woops, yup, fixed! Thanks
examples/README.md
Outdated
|
|
||
| ## Jupyter Notebook Example (no experimental read cache) | ||
|
|
||
| #### Prerequisite |
There was a problem hiding this comment.
The example uses GPU, so you will also need to enable GPU on the node pool if you are using a standard cluster.
You can refer to https://github.com/GoogleCloudPlatform/gcs-fuse-csi-driver/tree/main/examples#prerequisites here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds simple support for utilizing the GCSFuse experimental cache. To do this, it detects whether the user has passed in experimental-local-file-cache to their mount options, and if so, adds an emptydir volume mount pointing to ephemeral local ssds (that have to have been previously set up by the user) and points the cache at them.
@songjiaxun please let me know if there's a suitable readme for me to add structions on how to add a cluster/node pool w/ local ssds.