Incorporate review comments

GoogleCloudPlatform · Aug 9, 2024 · bc54a78 · bc54a78
1 parent 9542b72
commit bc54a78
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/cfg/types.go b/cfg/types.go
@@ -35,7 +35,7 @@ func (o *Octal) UnmarshalText(text []byte) error {
  return nil
 }
 
-func (o Octal) MarshalText() (text []byte, err error) {
+func (o Octal) MarshalText() (text []byte, _ error) {
  return []byte(strconv.FormatInt(int64(o), 8)), nil
 }
 

diff --git a/cmd/legacy_main.go b/cmd/legacy_main.go
@@ -297,7 +297,7 @@ func runCLIApp(c *cli.Context) (err error) {
  // if these are already being logged into a log-file, otherwise
  // there will be duplicate logs for these in both places (stdout and log-file).
  if newConfig.Foreground || newConfig.Logging.FilePath == "" {
- logger.Logger().Info("GCSFuse config", "config", newConfig)
+ logger.SLogger().Info("GCSFuse config", "config", newConfig)
  }
 
  // The following will not warn if the user explicitly passed the default value for StatCacheCapacity.

diff --git a/internal/logger/logger.go b/internal/logger/logger.go
@@ -42,11 +42,11 @@ var (
  defaultLogger *slog.Logger
 )
 
-// Logger exports the slog logger.
+// SLogger exports the slog logger.
 // This allows one to use the full breadth of features provided by slog.
 //
 // TODO: export defaultLogger instead of using this function.
-func Logger() *slog.Logger {
+func SLogger() *slog.Logger {
  return defaultLogger
 }