Change to pointer

GoogleCloudPlatform · Aug 7, 2024 · e4ffc6b · e4ffc6b
1 parent 8743565
commit e4ffc6b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/cfg/stringify.go → cfg/types.go b/cfg/stringify.go → cfg/types.go
@@ -35,8 +35,8 @@ func (o *Octal) UnmarshalText(text []byte) error {
 	return nil
 }
 
-func (o *Octal) MarshalText() (text []byte, err error) {
-	return []byte(strconv.FormatInt(int64(*o), 8)), nil
+func (o Octal) MarshalText() (text []byte, err error) {
+	return []byte(strconv.FormatInt(int64(o), 8)), nil
 }
 
 // Protocol is the datatype that specifies the type of connection: http1/http2/grpc.

diff --git a/cfg/stringify_test.go → cfg/types_test.go b/cfg/stringify_test.go → cfg/types_test.go
@@ -21,7 +21,7 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func TestOctalFieldInConfigStringify(t *testing.T) {
+func TestOctalTypeInConfigStringify(t *testing.T) {
 	c := Config{
 		FileSystem: FileSystemConfig{
 			DirMode: 0755,
@@ -31,15 +31,15 @@ func TestOctalFieldInConfigStringify(t *testing.T) {
 	str, err := util.Stringify(&c)
 
 	if assert.NoError(t, err) {
-		assert.Equal(t, "", str)
+		assert.Equal(t, "file-system:\n    dir-mode: \"755\"\n", str)
 	}
 }
 func TestOctalStringify(t *testing.T) {
 	o := Octal(0765)
 
-	str, err := util.Stringify(o)
+	str, err := util.Stringify(&o)
 
 	if assert.NoError(t, err) {
-		assert.Equal(t, `"765"`, str)
+		assert.Equal(t, "\"765\"\n", str)
 	}
 }