use fio's job_start parameter to compute start and end time of fio jobs. #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes revert seq_rand_read_write.fio clean up PR
ashmeenkaur
requested review from
sethiay,
vadlakondaswetha and
raj-prince
as code owners
ashmeenkaur
changed the title
sethiay
reviewed
Oct 20, 2023
raj-prince
reviewed
Oct 20, 2023
raj-prince
reviewed
Oct 20, 2023
raj-prince
requested changes
Oct 20, 2023
raj-prince
reviewed
Oct 20, 2023
raj-prince
approved these changes
Oct 20, 2023
gargnitingoogle
pushed a commit
that referenced
this pull request
Oct 30, 2023
…bs. (#1457) * testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes revert seq_rand_read_write.fio clean up PR * revert local testing changes * remove unused files * clean up pr * review comments * review comments * added unit tests
gargnitingoogle
pushed a commit
that referenced
this pull request
Oct 31, 2023
…bs. (#1457) * testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes revert seq_rand_read_write.fio clean up PR * revert local testing changes * remove unused files * clean up pr * review comments * review comments * added unit tests
gargnitingoogle
pushed a commit
that referenced
this pull request
Nov 1, 2023
…bs. (#1457) * testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes revert seq_rand_read_write.fio clean up PR * revert local testing changes * remove unused files * clean up pr * review comments * review comments * added unit tests
gargnitingoogle
pushed a commit
that referenced
this pull request
Nov 28, 2023
…bs. (#1457) * testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes revert seq_rand_read_write.fio clean up PR * revert local testing changes * remove unused files * clean up pr * review comments * review comments * added unit tests
gargnitingoogle
pushed a commit
that referenced
this pull request
Nov 29, 2023
…bs. (#1457) * testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes revert seq_rand_read_write.fio clean up PR * revert local testing changes * remove unused files * clean up pr * review comments * review comments * added unit tests
gargnitingoogle
pushed a commit
that referenced
this pull request
Nov 29, 2023
…bs. (#1457) * testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes testing changes revert seq_rand_read_write.fio clean up PR * revert local testing changes * remove unused files * clean up pr * review comments * review comments * added unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fio runtime exceeds the configured value sometimes (ref: axboe/fio#1640). Because of this out computation of fio start and end time was not correct.
Updated the script to use job's "job_start" parameter to compute the start and end time of fio jobs. This PR also includes some clean ups to simplify the logic.
Link to the issue in case of a bug fix.
NA
Testing details