-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stringify tests #2122
Remove stringify tests #2122
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2122 +/- ##
==========================================
- Coverage 71.75% 71.73% -0.02%
==========================================
Files 101 101
Lines 11120 11120
==========================================
- Hits 7979 7977 -2
- Misses 2812 2814 +2
Partials 329 329
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"stringify" should not test actual flag being passed, that not part of stringify behaviour. that should be checked in integration or composite tests @kislaykishore please also add reference to any of the integration or composite test testing that behaviour in PR description for reference.
These tests attempt to test the behavior of stringify method but in reality don't serve much purpose for the following reasons: * This test doesn't really test whether the util.Stringify was called. * They test the behavior of util.Stringify but there are tests in util package that do that [here](https://github.com/GoogleCloudPlatform/gcsfuse/blob/2fb8bba983cd81270357bfc590ccb0d5b4e6fb76/internal/util/util_test.go#L151). * It's usually a nuisance while adding flags where the test breaks on new flag addition.
a823d1a
67f54b3
to
a823d1a
Compare
Created #2134 to create such an integration test. |
Description
These tests attempt to test the behavior of stringify method but in reality don't serve much purpose for the following reasons:
Link to the issue in case of a bug fix.
NA
Testing details