Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log new configuration #2309

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Log new configuration #2309

merged 8 commits into from
Aug 16, 2024

Conversation

kislaykishore
Copy link
Collaborator

@kislaykishore kislaykishore commented Aug 7, 2024

Description

Here is how the logs appear on Logs explorer:
JSON Format
image

Text Format
image

Link to the issue in case of a bug fix.

2239

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.10%. Comparing base (1643f75) to head (71dae5d).
Report is 6 commits behind head on master.

Files Patch % Lines
cfg/types.go 0.00% 2 Missing ⚠️
cmd/legacy_main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2309      +/-   ##
==========================================
+ Coverage   78.96%   79.10%   +0.13%     
==========================================
  Files         106      105       -1     
  Lines       11606    11619      +13     
==========================================
+ Hits         9165     9191      +26     
+ Misses       1980     1969      -11     
+ Partials      461      459       -2     
Flag Coverage Δ
unittests 79.10% <40.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore force-pushed the stringify branch 2 times, most recently from c852d23 to 6547d49 Compare August 8, 2024 06:36
@kislaykishore kislaykishore marked this pull request as ready for review August 8, 2024 06:37
@kislaykishore kislaykishore requested a review from a team as a code owner August 8, 2024 06:37
@kislaykishore kislaykishore requested review from ashmeenkaur, a team and gargnitingoogle and removed request for a team August 8, 2024 06:37
@kislaykishore kislaykishore force-pushed the stringify branch 2 times, most recently from b21695a to fc543fc Compare August 9, 2024 05:12
cmd/legacy_main.go Outdated Show resolved Hide resolved
@kislaykishore kislaykishore force-pushed the stringify branch 2 times, most recently from fc5a838 to 7a78b92 Compare August 9, 2024 06:35
Copy link
Collaborator Author

@kislaykishore kislaykishore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

cfg/types.go Show resolved Hide resolved
internal/logger/logger.go Outdated Show resolved Hide resolved
cmd/legacy_main.go Outdated Show resolved Hide resolved
@kislaykishore kislaykishore changed the title Log new configuration if new config is enabled Log new configuration Aug 9, 2024
ashmeenkaur
ashmeenkaur previously approved these changes Aug 9, 2024
Copy link
Collaborator

@gargnitingoogle gargnitingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from readability perspective.

I am not fully aware of the functional changes in the PR, so not commenting on that.

@kislaykishore kislaykishore merged commit 4b7fe76 into master Aug 16, 2024
13 of 14 checks passed
@kislaykishore kislaykishore deleted the stringify branch August 16, 2024 14:36
ashmeenkaur pushed a commit that referenced this pull request Aug 19, 2024
* Log new configuration
ashmeenkaur pushed a commit that referenced this pull request Aug 19, 2024
* Log new configuration
ashmeenkaur pushed a commit that referenced this pull request Aug 19, 2024
* Log new configuration
ashmeenkaur pushed a commit that referenced this pull request Aug 19, 2024
* Log new configuration
kislaykishore added a commit that referenced this pull request Aug 21, 2024
* Log new configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants