Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataplex): add quickstart for dataplex #9618

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jacspa96
Copy link
Contributor

Description

Fixes b/287183421

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: dataplex Issues related to the Dataplex API. labels Oct 31, 2024
@jacspa96 jacspa96 marked this pull request as ready for review October 31, 2024 09:55
@jacspa96 jacspa96 requested review from yoshi-approver and a team as code owners October 31, 2024 09:55
Copy link

snippet-bot bot commented Oct 31, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@jacspa96 jacspa96 changed the title Dataplex quickstart feat(dataplex): add quickstart for dataplex Oct 31, 2024
Copy link

@cerberus97 cerberus97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I think we should add a search call though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dataplex Issues related to the Dataplex API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants