feat(compute): add compute consistency group disks list #9687
+443
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…group_delete samples, created test
product-auto-label
bot
added
api: compute
TetyanaYahodska
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
TetyanaYahodska
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
TetyanaYahodska
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
TetyanaYahodska
added
kokoro:run
kokoro-team
removed
kokoro:run
TetyanaYahodska
added
kokoro:run
kokoro-team
removed
the
kokoro:run
kokoro-team
removed
the
kokoro:force-run
TetyanaYahodska
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
TetyanaYahodska
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
TetyanaYahodska
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
TetyanaYahodska
added
the
kokoro:run
TetyanaYahodska
requested review from
yoshi-approver and
a team
as code owners
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
11 tasks
minherz
reviewed
Nov 25, 2024
Comment on lines
+60
to
+71
| // If your disk has zonal location uncomment these lines | ||
| // try (DisksClient disksClient = DisksClient.create()) { | ||
| // AddResourcePoliciesDiskRequest request = | ||
| // AddResourcePoliciesDiskRequest.newBuilder() | ||
| // .setDisk(diskName) | ||
| // .setDisksAddResourcePoliciesRequestResource( | ||
| // DisksAddResourcePoliciesRequest.newBuilder() | ||
| // .addAllResourcePolicies(Arrays.asList(consistencyGroupUrl)) | ||
| // .build()) | ||
| // .setProject(project) | ||
| // .setZone(location) | ||
| // .build(); |
There was a problem hiding this comment.
I see this becomes a pattern (see #9682). Please create a stand-alone code sample or remove these comments. They aren't instrumental for using with documentation.
Comment on lines
+86
to
+88
| if (response.hasError()) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
this is anti-pattern. replace with throwing exception with error information.
Comment on lines
+60
to
+62
| if (response.hasError()) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
ditto: replace with throwing exception with error information.
Comment on lines
+50
to
+52
| if (response.hasError()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
ditto: replace with throwing exception with error information.
Comment on lines
+53
to
+55
| System.out.println( | ||
| "Disk consistency group resource policy deleted successfully: " | ||
| + consistencyGroupName); |
There was a problem hiding this comment.
no need for this in the code sample
Comment on lines
+55
to
+62
| //If your disk has zonal location uncomment these lines | ||
| //try (DisksClient disksClient = DisksClient.create()) { | ||
| // ListDisksRequest request = | ||
| // ListDisksRequest.newBuilder() | ||
| // .setProject(project) | ||
| // .setZone(disksLocation) | ||
| // .build(); | ||
| // DisksClient.ListPagedResponse response = disksClient.list(request); |
There was a problem hiding this comment.
delete the lines. if required, create a stand alone code sample.
| } | ||
|
|
||
| @Test | ||
| @Order(1) |
There was a problem hiding this comment.
please parallel the tests or replace it with mocked behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please review this PR after #9646
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only