fix: replace fully-qualified column names #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pg_catalog queries that include a fully-qualified column name in either a join clause or a where clause would fail, as the pg_catalog table names are replaced with a unqualified reference to a common table expression. This change adds an additional step to replace fully qualified column names of qualified table names that have been replaced, with column names that only include the table name and not the schema name. That is: `pg_catalog.pg_class.relname -> pg_class.relname` Fixes #1129
Codecov Report
@@ Coverage Diff @@
## postgresql-dialect #1158 +/- ##
========================================================
- Coverage 90.69% 90.63% -0.07%
- Complexity 2547 2553 +6
========================================================
Files 140 140
Lines 8546 8584 +38
Branches 1250 1259 +9
========================================================
+ Hits 7751 7780 +29
- Misses 536 541 +5
- Partials 259 263 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg_catalog queries that include a fully-qualified column name in either a join clause or a where clause would fail, as the pg_catalog table names are replaced with a unqualified reference to a common table expression.
This change adds an additional step to replace fully qualified column names of qualified table names that have been replaced, with column names that only include the table name and not the schema name. That is:
pg_catalog.pg_class.relname -> pg_class.relnameFixes #1129