Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed incomplete regex for hostname matching #1166

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

shivgautam
Copy link
Contributor

Description

Fixes #1165

Checklist

  • Tests pass
  • Lint pass: bundle exec rubocop
  • Please merge this PR for me once it is approved.

@shivgautam shivgautam requested a review from a team as a code owner August 24, 2023 04:44
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 24, 2023
Copy link
Contributor

@SandeepTuniki SandeepTuniki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivgautam shivgautam merged commit e777950 into main Aug 24, 2023
7 checks passed
@shivgautam shivgautam deleted the fix_regular_expressions_in_samples branch August 24, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Fix regular expression for hostnames
2 participants