Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor error reporting code sample #1171

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

minherz
Copy link
Contributor

@minherz minherz commented Sep 16, 2023

align code sample for error reporting with code in other languages (b/275730159):

  • use the "fixed" error message

align code sample for error reporting with code in other languages:
- use the "fixed" error message
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 16, 2023
@minherz minherz marked this pull request as ready for review September 16, 2023 01:33
@minherz minherz requested a review from a team as a code owner September 16, 2023 01:33
@minherz minherz self-assigned this Sep 16, 2023
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the internal issue; approving the update to bring the message in alignment with corresponding samples for other languages.

@dazuma dazuma merged commit 77da255 into main Sep 18, 2023
5 checks passed
@SandeepTuniki SandeepTuniki deleted the minherz/fix-275730159 branch September 19, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants