UI changes for check constraint support #979
Conversation
|
Please checkout package json file |
| } else if (this.checkIfCcColumn(colId)) { | ||
| let message = `Column ${spColName} is a part of`; | ||
| const dependencies = []; | ||
| if (this.checkIfPkColumn(colId)) { |
There was a problem hiding this comment.
code will never enter this block
|
|
||
| this.ccArray.value.forEach((cc: ICcTabData) => { | ||
| if (cc.spConstraintName && cc.spConstraintCondition) { | ||
| if (spCkArr.some(item => item.Name === cc.spConstraintName || item.Expr === cc.spConstraintCondition)) { |
There was a problem hiding this comment.
For two check constraints that are empty and have no name, this will throw an error, right?
There was a problem hiding this comment.
it will not throw error because of the constraint without name is also acceptable
* remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com>
taherkl
requested review from
darshan-sj and
Deep1998
and removed request for
a team
ui/package-lock.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "ui", | |||
| "version": "0.0.0", | |||
There was a problem hiding this comment.
why are there changes in this file ? Is it intended?
There was a problem hiding this comment.
yes we have removed the node-sql-parse package
There was a problem hiding this comment.
in that case why is there no change in package.json file? From where was this package removed
There was a problem hiding this comment.
updated the package.lock file, no there are no changes
ui/dist/ui/main.1cfa12bd9a851a7a.js
Outdated
There was a problem hiding this comment.
Please run ng build and check in the updated files matching index.html in ui/dist
Users can view details of check constraints in the Check Constraint tab.
Users will be able to add, delete, and edit check constraints.
Deletion of a column is restricted if it is used in a check constraint.
Validation is performed to prevent adding duplicate expressions or constraint names in check constraints.
Check constraints have been incorporated into the Spanner DDL query.
Integration with Verify Expression API
Fixes #<issue_number_goes_here>