Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: upgrade modules to use provider v6 #257

Merged
merged 11 commits into from
Nov 5, 2024

Conversation

daniel-cit
Copy link
Contributor

@daniel-cit daniel-cit commented Nov 2, 2024

This PR upgrade the modules to user Terraform Google provider v6.x

It includes upgrading project-factory module to v17 and associated submodules and also lb-http/serverless_negs submodule

@daniel-cit daniel-cit changed the title upgrade modules to user provider v6 chore!: upgrade modules to user provider v6 Nov 2, 2024
@daniel-cit
Copy link
Contributor Author

/gcbrun

@daniel-cit daniel-cit marked this pull request as ready for review November 4, 2024 20:24
@apeabody
Copy link
Contributor

apeabody commented Nov 4, 2024

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit!

docs/upgrading_to_cloud_run_v2_v0.14.0_from_v0.13.0.md Outdated Show resolved Hide resolved
@daniel-cit
Copy link
Contributor Author

@apeabody Could you please try to run the integration tests again?

@apeabody
Copy link
Contributor

apeabody commented Nov 5, 2024

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Nov 5, 2024

/gcbrun

@apeabody apeabody changed the title chore!: upgrade modules to user provider v6 fix!: upgrade modules to use provider v6 Nov 5, 2024
@apeabody apeabody merged commit 3312703 into GoogleCloudPlatform:main Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants