-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: upgrade modules to use provider v6 #257
Merged
apeabody
merged 11 commits into
GoogleCloudPlatform:main
from
daniel-cit:upgrade-modules-version
Nov 5, 2024
Merged
fix!: upgrade modules to use provider v6 #257
apeabody
merged 11 commits into
GoogleCloudPlatform:main
from
daniel-cit:upgrade-modules-version
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-cit
changed the title
upgrade modules to user provider v6
chore!: upgrade modules to user provider v6
Nov 2, 2024
/gcbrun |
daniel-cit
requested review from
prabhu34,
anamer,
gtsorbo,
q2w and
a team
as code owners
November 4, 2024 20:24
/gcbrun |
apeabody
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daniel-cit!
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
…grade-modules-version
@apeabody Could you please try to run the integration tests again? |
/gcbrun |
/gcbrun |
apeabody
approved these changes
Nov 5, 2024
apeabody
changed the title
chore!: upgrade modules to user provider v6
fix!: upgrade modules to use provider v6
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrade the modules to user Terraform Google provider v6.x
It includes upgrading
project-factory
module to v17 and associated submodules and alsolb-http/serverless_negs
submodule