Fix 6.0-related VCR failures and skip previously failing ones #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:01255de735833091f50389b76ccdfab1c3717a46] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
requested review from
ScottSuarez
and removed request for
a team
modular-magician
merged commit a45967b
into
GoogleCloudPlatform:main
4 of 5 checks passed
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-01255de735833091f50389b76ccdfab1c3717a46
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes hashicorp/terraform-provider-google#19209
Test failures sourced from GoogleCloudPlatform/magic-modules#11513 (comment)
TestAccCloudFunctionsFunction_firestorewas already investigated: Failing test(s): TestAccCloudFunctionsFunction_firestore hashicorp/terraform-provider-google#18072 (comment)TestAccComputeDisk_storagePoolSpecified,TestAccComputeInstance_bootDisk_storagePoolSpecified: Failing test(s): compute disk + storage pool hashicorp/terraform-provider-google#19199TestAccComputeInstance_confidentialHyperDiskBootDisk: Failing test(s): TestAccComputeInstance_confidentialHyperDiskBootDisk hashicorp/terraform-provider-google#19217TestAccComputeNetworkFirewallPolicyRule_multipleRules: Failing test(s): TestAccComputeNetworkFirewallPolicyRule_multipleRules hashicorp/terraform-provider-google#19218TestAccDataprocVirtualCluster_basic: Failing test(s): TestAccDataprocVirtualCluster_basic hashicorp/terraform-provider-google#19076TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update: Failing test(s): TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update hashicorp/terraform-provider-google#18007TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyBasicExample: Failing test(s): TestAccNetworkSecurityClientTlsPolicy_networkSecurityClientTlsPolicyAdvancedExample hashicorp/terraform-provider-google#18103Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11522