Skip to content

Commit

Permalink
fix(docker): update .NET SDK and ASP.NET base images (#312)
Browse files Browse the repository at this point in the history
Replace preview Alpine images with stable .NET 9.0 images in the 
Dockerfiles for both the editor and main application. This change 
ensures a more stable and reliable build environment by using the 
latest stable release, improving compatibility and reducing the 
risk of issues related to preview versions.
  • Loading branch information
GordonBeeming authored Nov 13, 2024
1 parent 7497c63 commit de3ddca
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/GordonBeemingCom.Editor/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ENV BRANCH_NAME=$A_BRANCH_NAME
RUN apk add icu-libs
ENV DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=false

FROM mcr.microsoft.com/dotnet/sdk:9.0-preview-alpine AS build
FROM mcr.microsoft.com/dotnet/sdk:9.0 AS build
WORKDIR /src
COPY ["global.json", "GordonBeemingCom.Editor/global.json"]
COPY ["Directory.*.props", "./"]
Expand Down
4 changes: 2 additions & 2 deletions src/GordonBeemingCom/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#See https://aka.ms/customizecontainer to learn how to customize your debug container and how Visual Studio uses this Dockerfile to build your images for faster debugging.

FROM mcr.microsoft.com/dotnet/aspnet:9.0-preview-alpine AS base
FROM mcr.microsoft.com/dotnet/aspnet:9.0 AS base
WORKDIR /app
EXPOSE 80
ENV ASPNETCORE_URLS=http://+:80
Expand All @@ -11,7 +11,7 @@ ENV BRANCH_NAME=$A_BRANCH_NAME
RUN apk add icu-libs
ENV DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=false

FROM mcr.microsoft.com/dotnet/sdk:9.0-preview-alpine AS build
FROM mcr.microsoft.com/dotnet/sdk:9.0 AS build
WORKDIR /src
COPY ["global.json", "GordonBeemingCom/global.json"]
COPY ["Directory.*.props", "./"]
Expand Down

0 comments on commit de3ddca

Please sign in to comment.