chore(*): remove Helvetica font (#197)

GovTechSG · May 31, 2024 · 2425b87 · 2425b87
2 parents 5a1f0e3 + 4e11053
commit 2425b87
Show file tree

Hide file tree

Showing 8 changed files with 70 additions and 84 deletions.
diff --git a/README.md b/README.md
diff --git a/coverage/lcov-report/base.css b/coverage/lcov-report/base.css
@@ -3,7 +3,7 @@ body, html {
   height: 100%;
 }
 body {
-    font-family: Helvetica Neue, Helvetica, Arial;
+    font-family: Arial;
     font-size: 14px;
     color:#333;
 }

diff --git a/docs/Stylings.md b/docs/Stylings.md
@@ -23,7 +23,7 @@ The following css custom variable are exposed to enable users to make modificati
 ```css
 
 :root {
-  --sgds-body-font-family: Helvetica;
+  --sgds-body-font-family: "Inter";
   --sgds-body-font-size: 5rem;
   --sgds-primary-rgb : 89,37,220;
   --sgds-secondary : #1f69ff;

diff --git a/index.html b/index.html
@@ -16,7 +16,7 @@
   src="https://dev.assets.developer.tech.gov.sg/console-components/gateway.es5.js" nonce={nonce || undefined}></script> -->
     <style>
         /* * {
-            font-family: "bootstrap-icons", system-ui, -apple-system, "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", "Liberation Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
+            font-family: "bootstrap-icons", system-ui, -apple-system, "Segoe UI", Roboto, Arial, "Noto Sans", "Liberation Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
         } */
 
         :root {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -42,7 +42,7 @@
   ],
   "license": "MIT",
   "dependencies": {
-    "@govtechsg/sgds": "^2.3.1",
+    "@govtechsg/sgds": "^2.3.2",
     "@lit-labs/react": "^1.0.9",
     "@open-wc/scoped-elements": "^2.2.0",
     "bootstrap": "^5.1.3",

diff --git a/src/components/Masthead/sgds-masthead.scss b/src/components/Masthead/sgds-masthead.scss
@@ -1,7 +1,7 @@
 
 
 :host{
-    --masthead-font-family: system-ui, -apple-system, "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", "Liberation Sans", sans-serif;
+    --masthead-font-family: system-ui, -apple-system, "Segoe UI", Roboto, Arial, "Noto Sans", "Liberation Sans", sans-serif;
     --masthead-text-color: hsl(0, 0%, 28%);
     --masthead-link-color: hsl(222, 63%, 50%);
     --masthead-link-color-hover: hsl(221, 64%, 55%);

diff --git a/src/utils/components.style.scss b/src/utils/components.style.scss
@@ -359,7 +359,7 @@
 
     /* Fonts */
     --sl-font-mono: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace;
-    --sl-font-sans: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif,
+    --sl-font-sans: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Arial, sans-serif,
       'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol';
     --sl-font-serif: Georgia, 'Times New Roman', serif;
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,7 +16,7 @@ @@
       src="https://dev.assets.developer.tech.gov.sg/console-components/gateway.es5.js" nonce={nonce || undefined}></script> -->
         <style>
             /* * {
-                font-family: "bootstrap-icons", system-ui, -apple-system, "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", "Liberation Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
+                font-family: "bootstrap-icons", system-ui, -apple-system, "Segoe UI", Roboto, Arial, "Noto Sans", "Liberation Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
             } */
             :root {
@@ Expand Down @@