Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add UserManager.getUserCount for versions with signature permissions #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add UserManager.getUserCount for versions with signature permissions #68

wants to merge 1 commit into from

Conversation

stuux
Copy link

@stuux stuux commented Jun 7, 2020

should solve issue #58

@stuux stuux closed this Aug 1, 2020
@thestinger
Copy link
Member

Why close this?

@thestinger
Copy link
Member

I just need time to properly test and review changes like this and it has to be mirrored for AttestationServer. It can't be done only for the Auditor app.

This is changing the binary format of the attestation message so it will break compatibility unless it's incorporated into an increase of the protocol version which needs to be carefully done and tested.

@thestinger thestinger reopened this Aug 1, 2020
@thestinger thestinger force-pushed the main branch 7 times, most recently from ac2dde3 to 6a0e6c2 Compare May 14, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stuux @thestinger