-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
786 add ppv to total inventory report #814
Open
tekHudson
wants to merge
12
commits into
master
Choose a base branch
from
786-add-ppv-to-total-inventory-report
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
077b372
Update columns and add new data, reafactor total to reduce calculations
tekHudson 74f0d25
Add PPV calculations and total, total not working as anticipated
tekHudson 01babd2
Reorganize method and add 1ywarago for start date for TIV
tekHudson 2752e7e
scope deleted items to those deleted after start of reporting period
tekHudson ddf18ad
rearange comments
tekHudson cb00189
Fix display of totals
tekHudson 809d401
Display and total balse on end of day comparison, add missing unscoping
tekHudson 1ae5630
Robocop fixes
tekHudson a00937c
PR feedback
tekHudson 0868fda
PR feedback
tekHudson e1fa5c0
Use monetary-value class instead of monetary-value-(1,2)
smellsblue 761b072
Remove unneeded instance variables, add total header
tekHudson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,33 @@ | ||
<table class="table table-striped table-responsive data-table"> | ||
<thead> | ||
<tr> | ||
<th class="sort-asc">Description</th> | ||
<th class="text-center monetary-value">Value</th> | ||
<th class="sort-asc">Category</th> | ||
<th>Item</th> | ||
<th class="text-center num-value">Count</th> | ||
<th class="text-center monetary-value-1">Value</th> | ||
<th class="text-center monetary-value-2">PPV</th> | ||
</tr> | ||
</thead> | ||
|
||
<tbody> | ||
<% report.each do |description, value| %> | ||
<% report.each do |category_name, item_name, count, value, ppv| %> | ||
<tr> | ||
<td><%= description %></td> | ||
<td><%= category_name %></td> | ||
<td><%= item_name %></td> | ||
<td class="text-center"><%= count %></td> | ||
<td class="text-center"><%= number_to_currency value, precision: 2 %></td> | ||
<td class="text-center"><%= number_to_currency ppv, precision: 2 %></td> | ||
</tr> | ||
<% end %> | ||
</tbody> | ||
|
||
<tfoot> | ||
<tr> | ||
<th></th> | ||
<th class="text-center"><%= number_to_currency report.total_value, precision: 2 %></th> | ||
<th></th> | ||
<th class="text-center"></th> | ||
<th class="text-center"></th> | ||
<th class="text-center"></th> | ||
</tr> | ||
</tfoot> | ||
</table> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for @LisaJBlanchard : Do you want the total at the bottom of these reports to show the total for all pages of the report, or just the current page being viewed? If it should be the total for just this page of data, should there be another place that includes the full total?