Add testing setup #2177
Open
Add testing setup #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue with Chromium connecting to the Docker container via the WebSocket.
This is the minimum supported GravityView version
Mwalek
force-pushed
the
basic-test-setup
branch
from
98af9c5 to
4b86280
Compare
|
@Mwalek, could you please explain why you're initializing E2E-related code inside the plugin loader, and what other solutions have you explored? Ideally, the plugin should not be aware of tests. |
|
@mrcasual it was added there as a temporary measure. I was meant to ask you about how best to initilaze the importer, but never got around to it, sorry about that. I'm not sure how to load the importer without autoloading or activating it as a regular or MU plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💾 Build file (bb32bb4).