Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node and WP versions #1585

Open
wants to merge 1 commit into
base: hot-patch
Choose a base branch
from
Open

Conversation

jakejackson1
Copy link
Member

Description

WIP to upgrade the JS dependencies.

Testing instructions

Screenshots

Checklist:

  • I've tested the code.
  • My code is easy to read, follow, and understand
  • My code follows the accessibility standards.
  • My code has proper inline documentation / docblocks.

Additional Comments

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 92.46002% with 99 lines in your changes missing coverage. Please review.

Project coverage is 92.72%. Comparing base (fb70e5c) to head (6b1908f).
Report is 7 commits behind head on hot-patch.

Files with missing lines Patch % Lines
...s/js/react/components/FontManager/FontListItems.js 87.03% 13 Missing and 1 partial ⚠️
src/assets/js/react/reducers/fontManagerReducer.js 89.38% 12 Missing ⚠️
...eact/components/FontManager/AddUpdateFontFooter.js 85.48% 9 Missing ⚠️
...js/react/components/FontManager/FontManagerBody.js 94.93% 8 Missing ⚠️
...ct/components/Template/TemplateHeaderNavigation.js 80.00% 8 Missing ⚠️
...ets/js/react/components/FontManager/FontVariant.js 78.12% 7 Missing ⚠️
src/assets/js/react/components/ShowMessage.js 80.55% 6 Missing and 1 partial ⚠️
...ets/js/react/components/FontManager/FontManager.js 76.19% 4 Missing and 1 partial ⚠️
.../js/react/components/Template/TemplateContainer.js 73.68% 4 Missing and 1 partial ⚠️
src/assets/js/react/sagas/fontManager.js 92.30% 4 Missing ⚠️
... and 12 more
Additional details and impacted files
@@              Coverage Diff               @@
##           hot-patch    #1585       +/-   ##
==============================================
+ Coverage      75.68%   92.72%   +17.04%     
==============================================
  Files            251       58      -193     
  Lines          13612     1526    -12086     
  Branches         370      420       +50     
==============================================
- Hits           10302     1415     -8887     
+ Misses          3302      103     -3199     
  Partials           8        8               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kielllll
Copy link

image

@kielllll
Copy link

kielllll commented Nov 6, 2024

After the updates, found 25 failed tests on e2e

image

@jakejackson1 jakejackson1 marked this pull request as ready for review November 11, 2024 04:33
@jakejackson1
Copy link
Member Author

  1. Remove deprecated babel proposal packages (done)
  2. Move from standard to wp scripts (WIP)
  3. Remove unused api call
  4. Update doc blocks
  5. Remove React PropType from production build https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types

@kielllll kielllll force-pushed the js-dependencies branch 6 times, most recently from 4abe494 to 8743911 Compare November 15, 2024 03:21
@jakejackson1
Copy link
Member Author

Issues:

  1. superagent to fetch transition: throw exception if ! response.ok
  2. AJAX responses: wp_die() cannot set status code if content already output

@kielllll kielllll force-pushed the js-dependencies branch 3 times, most recently from b62ce47 to a17e5cc Compare November 26, 2024 02:14
@kielllll kielllll self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants