Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we have ignored validation of default values. These are given by us, as a field value of the configuration property. This would be a valid configuration that causes no errors during init:
But it's obviously wrong and will cause, sooner or later, problems elsewhere. That's why I believe is correct to validate default values as well.
In the best case, we would validate these during compile time, not during run time. But some of the properties are paths and config related to the running system, so we are unable to determine if the value is correct or not during compilation. Runtime check is the next best thing to avoid problems later in the execution.
Notes for Reviewers