Copy widget to dashboard: filter dashboards by permissions #20089
+52
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
force-pushed
the
fix-copy-to-dashboard-only-list-allowed-dashboards
branch
from
1861e95
to
520c016
Compare
linuspahl
reviewed
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this change, the list of dashboards in the copy-to dialog for a widget contained all dashboards. Now only those dashboards are listed that the user actually has permissions to change.
fixes #7331
Motivation and Context
How Has This Been Tested?
manually tested by sharing dashboard between users and logging in/opening the copy dialog
Screenshots (if appropriate):
Types of changes
Checklist: