Parse remote reindex task response failures #20095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todvora
changed the title
…lculation, unify with IndexMigrationProgress
moesterheld
reviewed
Aug 9, 2024
| .map(RemoteReindexMigration::indexProgress) | ||
| .reduce(BigDecimal.ZERO, BigDecimal::add); | ||
|
|
||
| return sum.divide(BigDecimal.valueOf(indices.size()), 4, RoundingMode.HALF_UP).scaleByPowerOfTen(2).intValue(); |
There was a problem hiding this comment.
could this lead to a wrong result since i.progress() == null is filtered out above and included here by simply using size()?
There was a problem hiding this comment.
no, I see. if they don't have progress they shouldn't be accounted for in the percentage anyway and be treated like 0 progress.
moesterheld
requested changes
Aug 9, 2024
moesterheld
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is yet another data structure in the opensearch task response that can hold errors. We need to be able to parse this structure and aggregate it.
/nocl
Description
Errors in this part of the response contain runtime problems during the index migration task. For example if the target index disappears during migration (deleted by our retention strategy).
How Has This Been Tested?
Manually + unit test for parsing
Screenshots (if appropriate):
Types of changes
Checklist: