Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pbkdf2 hash function for FIPS 140-2 support #20658

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

kroepke
Copy link
Member

@kroepke kroepke commented Oct 7, 2024

Description

Adding a new password hash function for use with FIPS 140-2 deployments.

Motivation and Context

If enabled through setting user_password_default_algorithm to pbkdf2 the only hash function for user passwords is PBKDF2WithHmacSHA512 which is the recommend one to use.
The iterations default to 10000, which is rather slow. This can be customized with user_password_pbkdf2_iterations.

The stored hash remembers which iteration number was used, however old hashed passwords are no longer usable and must be reset (this is true for bcrypt as well, so there's no new behavior introduced).

How Has This Been Tested?

Unit test.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@kroepke kroepke changed the title add pdkdf2 hash function for FIPS 140-2 support add pbkdf2 hash function for FIPS 140-2 support Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant