Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v1 #102

Merged
merged 8 commits into from
Jul 19, 2024
Merged

release v1 #102

merged 8 commits into from
Jul 19, 2024

Conversation

abhidg
Copy link
Contributor

@abhidg abhidg commented Jul 5, 2024

  • Format config in example as a code block
  • docs: fix typo
  • Bump version to 1.0.0, add classifiers

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (8853312) to head (9520d28).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   89.21%   89.23%   +0.01%     
==========================================
  Files          14       14              
  Lines         547      548       +1     
==========================================
+ Hits          488      489       +1     
  Misses         59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhidg abhidg marked this pull request as ready for review July 11, 2024 08:47
Copy link
Collaborator

@andreww andreww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

docs/source/conf.py Outdated Show resolved Hide resolved
@andreww
Copy link
Collaborator

andreww commented Jul 11, 2024

I think we probably have a bit of work to do with the documentation too - e.g. installation with pip currently points to the git repo rather than pypi. I guess we're going to end up with each tag (and release) here having it's own stable documentation on read the docs, so that'll probably help for future iterations. Anyway, I think it's probably worth pushing this out unless anybody else find issues.

@abhidg abhidg requested a review from andreww July 18, 2024 11:54
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but I have some comments.

pyproject.toml Outdated Show resolved Hide resolved
docs/source/installation.rst Show resolved Hide resolved
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@abhidg abhidg merged commit 20ed62b into main Jul 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants