-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v1 #102
release v1 #102
Conversation
abhidg
commented
Jul 5, 2024
- Format config in example as a code block
- docs: fix typo
- Bump version to 1.0.0, add classifiers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 89.21% 89.23% +0.01%
==========================================
Files 14 14
Lines 547 548 +1
==========================================
+ Hits 488 489 +1
Misses 59 59 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me
I think we probably have a bit of work to do with the documentation too - e.g. installation with pip currently points to the git repo rather than pypi. I guess we're going to end up with each tag (and release) here having it's own stable documentation on read the docs, so that'll probably help for future iterations. Anyway, I think it's probably worth pushing this out unless anybody else find issues. |
Also report __version__ in help message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall but I have some comments.
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>