Fluid crafts | Draft #1396
Draft
Fluid crafts | Draft #1396
+454
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds a Vanilla-styled recipe type that allows draining of fluids from a container with a fluid handling capability.
Implementation Details
2 main classes, both made for the main recipe, with 2 tweaked files for testing. The names of the classes are definitely subject to change and probably should be more generic, as these are a bit strangely named I'll admit. Currently, can only handle fluid of one type and amount (but as a byproduct if multiple inputs are defined with tanks, it would drain the same amount from them all I believe).
There is also a temporary tweak in VanillaRecipeHelper that makes the character
lbe replaced with the Bronze Drum, mostly for testing. Note: This currently only works with the bronze drum, as I couldn't think of a way to make it more generic (Consider this a TODO of this draft).Outcome
Adds a recipe type that allows for fluid aware crafting recipes.
Additional Information
This doesn't count buckets as "Holding fluids". It probably could given some tweaking, but I don't really know if it particularly matters all that much. Probably up for discussion. There was also lots of copy-pasting quite a bit of boilerplate for the builder and in the vanilla recipe helper (might be worth shifting stuff around in there to make it neater). The actual check and draining seem to work fine, and the serialization and networking appear to work correctly, but I'll defer the better specifics to others.
Potential Compatibility Issues
For basically every FluidStack, I defaulted to using LDLib's as it seemed to be the preferred method. However, lots of the current methods used want or return Forge FluidStacks, so
long->intcasts are common and could cause issues down the line for containers that are used that actually need the extra space of a long. Implementing helper functions that better handle these cases could probably help with this culling of precision in the future, if it's needed (though in its current form, like one recipe uses this and it sticks around till you make an LV machine that makes the recipe either so my blood, sweat, and tears went towards like 5 extra minutes of convenience at most already).I also forgot to ran spotless before this. I'll run it again in a bit to fix any complaints it might have. Same with culling imports, eventually.