Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I unified names between the API, Common, and Data sections.
Implementation Details
I'd take a look at how it is structured. It's not perfectly done yet, but the 3 folders are mostly complete, so we can make tweaks.
Outcome
It makes the system pretty easy: API, Common, Data.
Very linear and makes it easier to find. Should help with integration of other mods. New folders would have to be added for new additions, like a
armor/
folder in each section for new armors.ALSO, IT RUNS AND HAS NO ISSUES I'VE ENCOUNTERED
Additional Information
Inside the folders are pretty messy rn, and a lot of refactoring is needed for actual code, but that would take ages and would be a bitch to merge.
Potential Compatibility Issues
My structure may not best fit the style of most people. I think the idea is pretty sound though.
./com/gregtechceu/gtceu/
./addons
and./integrations
../data
(GregTech),./addons
(GregTech Addons) and./integrations
(Outside Mods)../common
for Object Classes and./API
for behaviors.Note: Addons & Integrations should not have access directly to API or Common code. Instead, wrapper functions should be used that call API and Common functionalities.
I.e. No one outside of GTM developers should have to reference API or Common code directly.
./api, ./common, ./data, ./addon
./integration