Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use baseurl in version switcher #955

Closed
wants to merge 2 commits into from
Closed

build: use baseurl in version switcher #955

wants to merge 2 commits into from

Conversation

tisonkun
Copy link
Contributor

Try to preview all the versions more smoothly on Cloudflare pages.

Copy link

cloudflare-workers-and-pages bot commented May 15, 2024

Deploying greptime-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e5b730a
Status: ✅  Deploy successful!
Preview URL: https://d5bd07c6.greptime-docs.pages.dev
Branch Preview URL: https://baseurl.greptime-docs.pages.dev

View logs

@tisonkun tisonkun marked this pull request as draft May 15, 2024 01:34
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as ready for review May 15, 2024 01:44
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as draft May 15, 2024 02:22
@tisonkun
Copy link
Contributor Author

Different versions stay in different SPA and thus they have different baseUrl. It's hard to do in page nav but we should find a way to pass the host and construct the external link with the deploy host url.

@tisonkun tisonkun closed this May 15, 2024
@tisonkun tisonkun deleted the baseurl branch May 15, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant