Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds build_info table #2969

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Dec 20, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Adds a new table information_schema.build_info:

> select * from information_schema.build_info;
+--------------------+------------------------------------------+------------------+-----------+-------------+
| git_branch         | git_commit                               | git_commit_short | git_dirty | pkg_version |
+--------------------+------------------------------------------+------------------+-----------+-------------+
| feature/build-info | 6e33e9921a89d8577d09f180cbe90b166e87628d | 6e33e99          | true      | 0.4.4       |
+--------------------+------------------------------------------+------------------+-----------+-------------+
1 row in set (0.09 sec)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2931

@killme2008 killme2008 marked this pull request as ready for review December 21, 2023 11:14
@killme2008 killme2008 mentioned this pull request Dec 21, 2023
37 tasks
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ac47e9) 85.85% compared to head (9688129) 85.37%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2969      +/-   ##
===========================================
- Coverage    85.85%   85.37%   -0.49%     
===========================================
  Files          770      779       +9     
  Lines       123951   125428    +1477     
===========================================
+ Hits        106424   107088     +664     
- Misses       17527    18340     +813     

Copy link
Contributor

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Dec 21, 2023
Merged via the queue into GreptimeTeam:develop with commit 054bca3 Dec 21, 2023
23 checks passed
@killme2008 killme2008 deleted the feature/build-info branch January 16, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants