Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds character_sets, collations and events etc. #3017

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat: adds character_sets, collations and events etc. #3017

merged 1 commit into from
Dec 28, 2023

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Dec 27, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add some tables to information_schema:

  • character_sets
  • collations
  • collation_character_set_applicability
  • check_constraints
  • events

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2931

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Dec 27, 2023
@killme2008 killme2008 marked this pull request as ready for review December 27, 2023 08:26
@killme2008 killme2008 added the C-user-experience Category User Experience label Dec 27, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (feec4e2) 85.70% compared to head (a26c391) 85.21%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3017      +/-   ##
===========================================
- Coverage    85.70%   85.21%   -0.50%     
===========================================
  Files          784      784              
  Lines       126856   126957     +101     
===========================================
- Hits        108726   108182     -544     
- Misses       18130    18775     +645

zhongzc
zhongzc approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 changed the base branch from develop to main December 28, 2023 03:50
shuiyisong
shuiyisong approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@shuiyisong shuiyisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuiyisong shuiyisong added this pull request to the merge queue Dec 28, 2023
Merged via the queue into GreptimeTeam:main with commit af13eea Dec 28, 2023
35 of 36 checks passed
@killme2008 killme2008 deleted the feature/infomration-schema-functions-part3 branch January 16, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuiyisong shuiyisong shuiyisong approved these changes

@zhongzc zhongzc zhongzc approved these changes

@waynexia waynexia Awaiting requested review from waynexia

Assignees
No one assigned
Labels
C-user-experience Category User Experience docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@killme2008 @zhongzc @shuiyisong