Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some tables for information_schema #3060

Merged
merged 14 commits into from
Jan 2, 2024

Conversation

dimbtp
Copy link
Contributor

@dimbtp dimbtp commented Dec 31, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add some tables that is not implemented for information_schema, includes: GLOBAL_STATUS, OPTIMIZER_TRACE, PARAMETERS, PROFILING, REFERENTIAL_CONSTRAINTS, ROUTINES, SCHEMA_PRIVILEGES, SESSION_STATUS, TABLE_PRIVILEGES, TRIGGERS.

As for TABLESPACES table, according to mysql doc: This table is unused. It is deprecated; expect it to be removed in a future MySQL release. Other INFORMATION_SCHEMA tables may provide related information. Should I skip this table?

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2931

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: L labels Dec 31, 2023
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f735f73) 85.35% compared to head (7d1ebe1) 84.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3060      +/-   ##
==========================================
- Coverage   85.35%   84.94%   -0.42%     
==========================================
  Files         800      800              
  Lines      129395   129572     +177     
==========================================
- Hits       110441   110060     -381     
- Misses      18954    19512     +558     

@github-actions github-actions bot added docs-required This change requires docs update. docs-not-required This change does not impact docs. and removed docs-not-required This change does not impact docs. docs-required This change requires docs update. labels Dec 31, 2023
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy new year, a great work! Thank you.

@evenyag
Copy link
Contributor

evenyag commented Jan 2, 2024

As for TABLESPACES table, according to mysql doc: This table is unused. It is deprecated; expect it to be removed in a future MySQL release. Other INFORMATION_SCHEMA tables may provide related information. Should I skip this table?

I think we could ignore this table. cc @sunng87 @killme2008

@killme2008
Copy link
Contributor

As for TABLESPACES table, according to mysql doc: This table is unused. It is deprecated; expect it to be removed in a future MySQL release. Other INFORMATION_SCHEMA tables may provide related information. Should I skip this table?

I think we could ignore this table. cc @sunng87 @killme2008

Yes, of course

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

src/catalog/src/information_schema/memory_table/tables.rs Outdated Show resolved Hide resolved
@evenyag evenyag enabled auto-merge January 2, 2024 03:34
Co-authored-by: Yingwen <realevenyag@gmail.com>
@killme2008
Copy link
Contributor

I commit the suggestion and it will be merged automatically.

@evenyag evenyag added this pull request to the merge queue Jan 2, 2024
Merged via the queue into GreptimeTeam:main with commit c4d7b0d Jan 2, 2024
15 checks passed
@dimbtp dimbtp deleted the feature/information-schema branch January 2, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants