Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the CreateFlowProcedure #3810

Merged
merged 13 commits into from
Apr 29, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 26, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3664

What's changed and what's your intention?

  1. Add FlowMetadataManager and FlowMetadataAllocator to DdlContext.
  2. Implement the CreateFlowProcedure

Tests will be added via another PR.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested review from v0y4g3r, MichaelScofield and a team as code owners April 26, 2024 09:08
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 26, 2024
@WenyXu WenyXu force-pushed the feat/create-flow-task-procedure branch from fdbc129 to ecdb159 Compare April 26, 2024 09:14
@WenyXu WenyXu requested a review from fengjiachun April 26, 2024 09:16
@WenyXu WenyXu force-pushed the feat/create-flow-task-procedure branch from ecdb159 to a590f26 Compare April 26, 2024 09:28
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 39.82869% with 281 lines in your changes are missing coverage. Please review.

Project coverage is 85.33%. Comparing base (7ef18c0) to head (2590213).
Report is 2 commits behind head on main.

❗ Current head 2590213 differs from pull request most recent head d9cccd5. Consider uploading reports for the commit d9cccd5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3810      +/-   ##
==========================================
- Coverage   85.74%   85.33%   -0.41%     
==========================================
  Files         951      954       +3     
  Lines      162837   163049     +212     
==========================================
- Hits       139620   139139     -481     
- Misses      23217    23910     +693     

@WenyXu WenyXu force-pushed the feat/create-flow-task-procedure branch 2 times, most recently from 78b6626 to 0efe8ac Compare April 26, 2024 13:19
@WenyXu WenyXu force-pushed the feat/create-flow-task-procedure branch from 0efe8ac to 7b663e5 Compare April 28, 2024 03:37
@WenyXu WenyXu changed the title feat: implement the CreateFlowTaskProcedure feat: implement the CreateFlowProcedure Apr 28, 2024
@WenyXu WenyXu force-pushed the feat/create-flow-task-procedure branch 2 times, most recently from b88f1d1 to df2fee1 Compare April 29, 2024 04:34
@WenyXu WenyXu mentioned this pull request Apr 29, 2024
3 tasks
src/common/meta/src/ddl/create_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_flow.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the feat/create-flow-task-procedure branch from df2fee1 to 4ee2b9f Compare April 29, 2024 09:46
@WenyXu
Copy link
Member Author

WenyXu commented Apr 29, 2024

@fengjiachun @MichaelScofield PTAL

src/common/meta/src/ddl/create_flow.rs Show resolved Hide resolved
src/common/meta/src/ddl/create_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_flow/check.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_flow/metadata.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_flow/metadata.rs Outdated Show resolved Hide resolved
src/common/meta/src/error.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the feat/create-flow-task-procedure branch from 2590213 to e041c18 Compare April 29, 2024 11:04
@WenyXu WenyXu force-pushed the feat/create-flow-task-procedure branch from e041c18 to f9c02f6 Compare April 29, 2024 11:05
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

@MichaelScofield
Copy link
Collaborator

Just lock the sink table name and we are good to go.

@WenyXu WenyXu enabled auto-merge April 29, 2024 12:21
@WenyXu WenyXu added this pull request to the merge queue Apr 29, 2024
Merged via the queue into GreptimeTeam:main with commit b493ea1 Apr 29, 2024
20 checks passed
@WenyXu WenyXu deleted the feat/create-flow-task-procedure branch April 29, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants