Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove some admin APIs #3821

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented Apr 28, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR removes some admin APIs as they have been replaced by the information schema.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 28, 2024
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun tisonkun enabled auto-merge April 28, 2024 03:14
@waynexia waynexia changed the title chore: remove some admin APIs refactor!: remove some admin APIs Apr 28, 2024
@github-actions github-actions bot added the breaking-change This pull request contains breaking changes. label Apr 28, 2024
@tisonkun tisonkun added this pull request to the merge queue Apr 28, 2024
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.45%. Comparing base (3112ced) to head (fc3f26d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3821      +/-   ##
==========================================
- Coverage   85.63%   85.45%   -0.19%     
==========================================
  Files         955      952       -3     
  Lines      163100   162684     -416     
==========================================
- Hits       139669   139014     -655     
- Misses      23431    23670     +239     

Merged via the queue into GreptimeTeam:main with commit ed8b136 Apr 28, 2024
26 checks passed
@fengjiachun fengjiachun deleted the chore/rm-some-admin-api branch April 28, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This pull request contains breaking changes. docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants