Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove TableMetaKey trait #3837

Merged
merged 4 commits into from
Apr 30, 2024
Merged

refactor: remove TableMetaKey trait #3837

merged 4 commits into from
Apr 30, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 29, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Wait for #3835

use MetaKey trait instead of TableMetaKey.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 29, 2024
@WenyXu WenyXu force-pushed the refactor/remove-table-meta-trait branch from dd90929 to 8eb280c Compare April 29, 2024 14:43
@WenyXu WenyXu force-pushed the refactor/remove-table-meta-trait branch from 8eb280c to 09eef56 Compare April 30, 2024 03:42
@WenyXu WenyXu marked this pull request as ready for review April 30, 2024 03:42
@WenyXu WenyXu requested review from MichaelScofield and a team as code owners April 30, 2024 03:42
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.34921% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 85.31%. Comparing base (20cbc03) to head (f255035).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3837      +/-   ##
==========================================
- Coverage   85.63%   85.31%   -0.33%     
==========================================
  Files         954      954              
  Lines      163214   163325     +111     
==========================================
- Hits       139771   139341     -430     
- Misses      23443    23984     +541

@WenyXu WenyXu requested a review from fengjiachun April 30, 2024 06:07
fengjiachun
fengjiachun approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Apr 30, 2024
Merged via the queue into GreptimeTeam:main with commit 81f3007 Apr 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WenyXu @MichaelScofield @fengjiachun