Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuzz): add insert logical table target #3842

Merged

Conversation

CookiePieWw
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3741 and #3174

What's changed and what's your intention?

Fuzz test for insertions in the metric engine. Since the order of columns of logical table is not the same as declaration, all the insertions have a explicit column list.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@CookiePieWw CookiePieWw requested a review from a team as a code owner April 30, 2024 06:52
@github-actions github-actions bot added Invalid PR Title docs-not-required This change does not impact docs. labels Apr 30, 2024
@CookiePieWw CookiePieWw changed the title Insert logical table fuzz test feat(fuzz): add insert logical table target Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (20cbc03) to head (85d364a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3842      +/-   ##
==========================================
- Coverage   85.63%   85.28%   -0.36%     
==========================================
  Files         954      954              
  Lines      163214   163324     +110     
==========================================
- Hits       139771   139290     -481     
- Misses      23443    24034     +591     

@WenyXu WenyXu requested review from waynexia and WenyXu April 30, 2024 08:36
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this can conflict to #3788.

@WenyXu I'd merge this one and perhaps you can rebase #3788 later.

@tisonkun tisonkun added this pull request to the merge queue May 1, 2024
Merged via the queue into GreptimeTeam:main with commit 573d369 May 1, 2024
22 checks passed
@CookiePieWw CookiePieWw deleted the insert-logical-table-fuzz-test branch May 1, 2024 04:09
@WenyXu
Copy link
Member

WenyXu commented May 1, 2024

I suppose this can conflict to #3788.

@WenyXu I'd merge this one and perhaps you can rebase #3788 later.

Thanks, I will fix it.

@WenyXu WenyXu self-assigned this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants