-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade rust toolchain to fix ci issues on Windows #3898
Conversation
8b9918a
to
a25757c
Compare
windows-2019
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3898 +/- ##
=======================================
Coverage 85.81% 85.81%
=======================================
Files 965 964 -1
Lines 165015 165007 -8
=======================================
+ Hits 141602 141606 +4
+ Misses 23413 23401 -12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fix #3902?
I think so. |
The dev-builder action 💨 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
https://github.com/GreptimeTeam/greptimedb/actions/runs/9009678033/job/24754350747
Upgrading the rust toolchain should fix this.
TODO
We also need to release a new dev-builder after this PR: https://github.com/GreptimeTeam/greptimedb/actions/workflows/release-dev-builder-images.yaml
Checklist