Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade rust toolchain to fix ci issues on Windows #3898

Merged
merged 7 commits into from
May 14, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented May 9, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

https://github.com/GreptimeTeam/greptimedb/actions/runs/9009678033/job/24754350747

     Running `target\debug\sqlness-runner.exe`
error: process didn't exit successfully: `target\debug\sqlness-runner.exe` (exit code: 0xc0000142, STATUS_DLL_INIT_FAILED)
Error: Process completed with exit code 1.

Upgrading the rust toolchain should fix this.

TODO

We also need to release a new dev-builder after this PR: https://github.com/GreptimeTeam/greptimedb/actions/workflows/release-dev-builder-images.yaml

  • Release dev-builder

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 9, 2024
@evenyag evenyag force-pushed the ci/windows-image branch 2 times, most recently from 8b9918a to a25757c Compare May 11, 2024 12:07
@evenyag evenyag changed the title ci: specify windows image to windows-2019 build: upgrade rust-toolchain to fix ci issues on Windows May 13, 2024
@evenyag evenyag changed the title build: upgrade rust-toolchain to fix ci issues on Windows build: upgrade rust toolchain to fix ci issues on Windows May 13, 2024
@evenyag evenyag marked this pull request as ready for review May 13, 2024 13:55
@evenyag evenyag requested a review from a team as a code owner May 13, 2024 13:55
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (be1eb4e) to head (38d5edc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3898   +/-   ##
=======================================
  Coverage   85.81%   85.81%           
=======================================
  Files         965      964    -1     
  Lines      165015   165007    -8     
=======================================
+ Hits       141602   141606    +4     
+ Misses      23413    23401   -12     

Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix #3902?

@evenyag
Copy link
Contributor Author

evenyag commented May 13, 2024

This should fix #3902?

I think so.

@waynexia waynexia enabled auto-merge May 14, 2024 03:39
@waynexia waynexia added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 6214180 May 14, 2024
39 of 47 checks passed
@waynexia waynexia deleted the ci/windows-image branch May 14, 2024 06:34
@evenyag
Copy link
Contributor Author

evenyag commented May 14, 2024

The dev-builder action 💨
https://github.com/GreptimeTeam/greptimedb/actions/runs/9075054114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants