-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add Configurable
trait
#3917
Merged
evenyag
merged 10 commits into
GreptimeTeam:main
from
zyy17:refactor/add-configurable-trait
May 15, 2024
Merged
refactor: add Configurable
trait
#3917
evenyag
merged 10 commits into
GreptimeTeam:main
from
zyy17:refactor/add-configurable-trait
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyy17
force-pushed
the
refactor/add-configurable-trait
branch
from
May 11, 2024 08:56
56a1842
to
67f0445
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3917 +/- ##
==========================================
- Coverage 85.77% 85.47% -0.30%
==========================================
Files 968 969 +1
Lines 166463 166503 +40
==========================================
- Hits 142782 142319 -463
- Misses 23681 24184 +503 |
zyy17
force-pushed
the
refactor/add-configurable-trait
branch
2 times, most recently
from
May 12, 2024 09:20
a8c1f71
to
ef75272
Compare
evenyag
reviewed
May 12, 2024
zyy17
force-pushed
the
refactor/add-configurable-trait
branch
from
May 14, 2024 10:30
ef75272
to
f54c812
Compare
zyy17
force-pushed
the
refactor/add-configurable-trait
branch
from
May 14, 2024 11:20
b8971b8
to
d53366a
Compare
zyy17
force-pushed
the
refactor/add-configurable-trait
branch
from
May 14, 2024 13:43
d53366a
to
bed8602
Compare
3 tasks
MichaelScofield
approved these changes
May 15, 2024
zyy17
force-pushed
the
refactor/add-configurable-trait
branch
from
May 15, 2024 03:12
bed8602
to
e6ec8ee
Compare
@evenyag PTAL |
evenyag
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Add the
Configurable
trait to make configuration more general.Add the new module
error.rs
andconfig.rs
incommon/config
. Most of the code are fromcmd/
:load_layer_options()
is from the originalcmd/options.rs
;cmd/error.rs
;Add
merge_with_cli_options()
to makeload_options()
more simple;Implement
Configurable
trait and changed some tests for{DatanodeOptions, FrontendOptions, MetasrvOptions, StandaloneOptions}
;Checklist