Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: store-addr to store-addrs #3925

Merged
merged 1 commit into from
May 13, 2024

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

The fish that got away from PR #3921

This PR renames store_addr to store_addrs in start command.
Use the alias mechanism aliases = ["store-addr"] to ensure forward compatibility.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.66%. Comparing base (60eb5de) to head (c4df63b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3925      +/-   ##
==========================================
- Coverage   85.98%   85.66%   -0.32%     
==========================================
  Files         963      963              
  Lines      164532   164533       +1     
==========================================
- Hits       141474   140951     -523     
- Misses      23058    23582     +524     

@tisonkun tisonkun added this pull request to the merge queue May 13, 2024
Merged via the queue into GreptimeTeam:main with commit 5d8084a May 13, 2024
22 checks passed
@fengjiachun fengjiachun deleted the feat/metasrv-store-addrs branch May 13, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants