Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(operator): reuse table info from table creation #3945

Merged
merged 1 commit into from
May 15, 2024
Merged

perf(operator): reuse table info from table creation #3945

merged 1 commit into from
May 15, 2024

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented May 15, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

... to eliminate redundant calls to catalog_manager.table(...).

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@zhongzc
perf(operator): reuse table info from creating
3779f40 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc requested a review from a team as a code owner May 15, 2024 08:42
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 15, 2024
@zhongzc zhongzc changed the title perf(operator): reuse table info from creating perf(operator): reuse table info from table creation May 15, 2024
fengjiachun
fengjiachun approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuiyisong shuiyisong requested a review from waynexia May 15, 2024 09:15
@shuiyisong shuiyisong added this pull request to the merge queue May 15, 2024
Merged via the queue into GreptimeTeam:main with commit 2a169f9 May 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhongzc @fengjiachun @waynexia @shuiyisong