Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use lld linker in windows tests #3946

Merged
merged 7 commits into from
May 15, 2024
Merged

ci: Use lld linker in windows tests #3946

merged 7 commits into from
May 15, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented May 15, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR attempts to Make Actions Pass Again, MAPA in short.

It switches the default linker to LLVM's lld which has lower memory consumption. It also enables logs for the test test_tls_file_change_watch.

The previous action cost 50m to compile tests...... Most time is spent in linking.
https://github.com/GreptimeTeam/greptimedb/actions/runs/9087338152/job/24981188499

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 15, 2024
@evenyag evenyag marked this pull request as ready for review May 15, 2024 09:22
@evenyag evenyag requested a review from a team as a code owner May 15, 2024 09:22
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (cfae276) to head (c9a942d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3946      +/-   ##
==========================================
- Coverage   85.70%   85.60%   -0.11%     
==========================================
  Files         969      971       +2     
  Lines      166649   166802     +153     
==========================================
- Hits       142834   142787      -47     
- Misses      23815    24015     +200     

@waynexia waynexia added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 529e344 May 15, 2024
39 of 47 checks passed
@waynexia waynexia deleted the ci/windows-test branch May 15, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants