Apply suggestions from code review

The other batch is done locally. Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
GridTools · May 14, 2024 · 2e1ebcd · 2e1ebcd
1 parent ec4d7ae
commit 2e1ebcd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -149,7 +149,7 @@ section-order = [
 "!tests/**.py" = ["PT"]  # Ignore `flake8-pytest-style` everywhere except in `tests/`
 "noxfile.py" = ["T20"]  # Ignore `flake8-print`
 "tests/**" = [
-  "T10",
-  "T20",  # Ignore `flake8-debugger` and `flake8-print`
-  "F841",  # Ignore assigned but not used; inside `with` to test if throw.
+  "T10", # Ignore `flake8-debugger`
+  "T20",  # Ignore `flake8-print`
+  "F841",  # Ignore `unused-variable` (inside `with` to test if throws)
 ]
diff --git a/src/jace/translator/jaxpr_translator_driver.py b/src/jace/translator/jaxpr_translator_driver.py
@@ -241,7 +241,7 @@ def map_jax_var_to_sdfg(
     def map_jax_var_to_sdfg(
         self,
         jax_var: str | jax_core.Atom | util.JaCeVar,
-        allow_fail: bool,
+        allow_fail: Literal[True],
     ) -> str | None: ...
 
     def map_jax_var_to_sdfg(

diff --git a/tests/test_jaxpr_translator_driver.py b/tests/test_jaxpr_translator_driver.py
@@ -20,7 +20,7 @@
 
 
 @pytest.fixture(scope="module")
-def alloc_driver():
+def translation_driver():
     """Returns an allocated driver instance."""
     name = "fixture_driver"
     driver = jtrans.JaxprTranslationDriver()