Skip to content

Commit

Permalink
Disabled the simplify pass again in the tests.
Browse files Browse the repository at this point in the history
I enabled the simplify pass in commit `411bd7bd` and it worked locally.
However, this was because I was not running it inside nox and using my own version of DaCe.
The bug in simplify was fixed in [PR#1603](spcl/dace#1603) which was merged _after_ 16.1 was released, thus the fix is not avaliable.
  • Loading branch information
philip-paul-mueller committed Sep 25, 2024
1 parent 090c3a2 commit e667854
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion tests/integration_tests/primitive_translators/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@
autouse=True,
params=[
optimization.NO_OPTIMIZATIONS,
optimization.DEFAULT_OPTIMIZATIONS,
pytest.param(
optimization.DEFAULT_OPTIMIZATIONS,
marks=pytest.mark.skip(
"Simplify bug 'https://github.com/spcl/dace/issues/1595'; resolved > 16.1"
),
),
],
)
def _set_compile_options(request) -> Generator[None, None, None]:
Expand Down

0 comments on commit e667854

Please sign in to comment.