chore: add new nox sessions to deal with requirements and venvs #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-paul-mueller
previously approved these changes
Jun 13, 2024
philip-paul-mueller
requested changes
Jun 13, 2024
philip-paul-mueller
approved these changes
Jun 14, 2024
noxfile.py
Outdated
| @nox.session(python=["3.10", "3.11", "3.12"]) | ||
| def venv(session: nox.Session) -> None: | ||
| """ | ||
| Sets up a Python development environment. Use as: `nox -s venv -- [dest_path] [req_preset] |
There was a problem hiding this comment.
I think you should swap req_preset with dest_path, and integrate the requirement in the path of the venv.
Because in most cases you want just to select an environment, but now wou have to specify both.
There was a problem hiding this comment.
The decision on the order of the arguments was on purpose to force the user to give a non-standard venv a different name. I added the requirements preset to the name of the venv now so the order can be safely changed, but the default name of the generated venvs are now more verbose, so it's not exactly a win-win, but I guess it's ok...
egparedes
changed the title
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add:
venv-3xxnox session to automatically create and setup development environmentsrequirementsnox session to automatically freeze and synchronize versions of requirements for development and testing across toolsrequirementsfolder with different sets of requirements for developmentChange:
daceRemove:
requirements-dev.txtfile is now a preset inside therequirementsfolder